Skip to content

chore: bump cosmos-sdk to 0.50.6 #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2024
Merged

chore: bump cosmos-sdk to 0.50.6 #642

merged 2 commits into from
May 21, 2024

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented May 21, 2024 •
edited by coderabbitai bot
Loading

Self explanatory

Summary by CodeRabbit

  • New Features

    • Introduced axoned query wait-tx command to wait for a transaction to be included in a block.
    • Added axoned query distribution rewards-by-validator command to query distribution rewards from a specific validator.

  • Changes

    • Renamed axoned query distribution rewards to axoned query distribution rewards-by-validator for clarity.
    • Removed the option to query rewards from a specific validator in axoned query distribution rewards.

  • Documentation

    • Updated documentation to reflect new and renamed commands.
    • Added examples and customization options for new commands.
    • Included default value for --mempool.max-txs flag in axoned_start.md.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 21, 2024 •
edited
Loading

Walkthrough

The documentation updates introduce significant command changes to the axoned tool. The event-query-tx-for command is replaced by wait-tx for transaction block inclusion. Distribution reward queries are refined, splitting the functionality into rewards for all delegators and rewards-by-validator for specific validators. Additionally, the --mempool.max-txs flag now has a default value in the axoned_start.md file.

Changes

Files/Paths Change Summaries
docs/command/axoned_query.md Removed event-query-tx-for, added wait-tx.
docs/command/axoned_query_distribution.md Renamed subcommand to rewards-by-validator and updated description.
docs/command/axoned_query_distribution_rewards-by-validator.md Introduced command rewards-by-validator for querying rewards from a specific validator.
docs/command/axoned_query_distribution_rewards.md Removed validator-specific option, focusing on all delegator rewards.
docs/command/axoned_query_wait-tx.md Introduced wait-tx command for waiting on transaction block inclusion.
docs/command/axoned_start.md Added default value -1 for --mempool.max-txs flag.

🐇
In the garden of code, new commands bloom,
wait-tx stands tall, no more query gloom.
Rewards now clear, by validator's tune,
mempool set right, under the coding moon.
🌕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bdeneux bdeneux marked this pull request as ready for review May 21, 2024 09:50
@bdeneux bdeneux requested review from amimart and ccamel May 21, 2024 09:50
@bdeneux bdeneux self-assigned this May 21, 2024
coderabbitai[bot]
coderabbitai bot reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between e28ba17 and 985a58f.
Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (6)
  • docs/command/axoned_query.md (2 hunks)
  • docs/command/axoned_query_distribution.md (1 hunks)
  • docs/command/axoned_query_distribution_rewards-by-validator.md (1 hunks)
  • docs/command/axoned_query_distribution_rewards.md (1 hunks)
  • docs/command/axoned_query_wait-tx.md (1 hunks)
  • docs/command/axoned_start.md (1 hunks)
Additional comments not posted (6)
docs/command/axoned_query_distribution_rewards.md (1)

3-3: The description succinctly explains the command's functionality. Ensure it aligns with the actual command behavior after the SDK update.

docs/command/axoned_query_distribution_rewards-by-validator.md (1)

1-3: The title and description clearly define the purpose of the new command. Ensure the description accurately reflects the command's functionality as implemented in the SDK.

docs/command/axoned_query_wait-tx.md (1)

1-3: The title and description are clear and effectively communicate the purpose of the new command. Ensure the implementation in the SDK matches this description.

docs/command/axoned_query_distribution.md (1)

23-24: The links to related commands are correctly updated to reflect the new and modified commands. This helps users navigate between related topics efficiently.

docs/command/axoned_query.md (1)

43-43: The link to the new axoned query wait-tx command is correctly added. This ensures users are aware of the new functionality available.

docs/command/axoned_start.md (1)

69-69: The updated default value for the --mempool.max-txs flag is clearly documented. This change is important for users to understand the new behavior of the mempool.

ccamel
ccamel approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 👍

@bdeneux bdeneux merged commit bacc8be into main May 21, 2024
19 checks passed
@bdeneux bdeneux deleted the chore/cosmos0.50.6 branch May 21, 2024 11:47
@bdeneux bdeneux mentioned this pull request May 21, 2024
Closed
@bdeneux bdeneux mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ccamel ccamel ccamel approved these changes

@amimart amimart amimart approved these changes

Assignees

@bdeneux bdeneux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdeneux @ccamel @amimart